Remove useStyles from HURUMap #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinkipruto
requested review from
kilemensi and
m453h
and removed request for
kilemensi
kilemensi
reviewed
Nov 29, 2024
kilemensi
added
the
chore
|
Headings look good now @kelvinkipruto but Select looks off. |
m453h
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Mostly looks good to me 🚀 I only have a few very minor issues
- There’s an issue with the Pin and Compare component when focused, I can see the shadow/tint slightly overlaps the border radius. Although this is visible in the deployed app, it’s more noticeable in the current version 👇
I played a bit with the CSS on the browser but explicitly setting the borderRadius on focus state kinda solves the problem:
"& .MuiSelect-filled:focus": {
borderRadius: theme.typography.pxToRem(6),
},
- Some of these icons look like they are cut at the bottom, Not sure why this is happening though might be a good idea to fix them on the same PR, and I was just thinking out loud since we are using 𝕏 instead of the bird as one of the social media icons on the footer, don't we need to update this one as well 🤔
|
@kilemensi @m453h @koechkevin Thi si ready fo another round of reviews. |
|
We are almost there, I'm not sure why this is happening but the dropdown items seem a bit off in terms of size (probably missing some padding) and there is some extra margin on the left.
|
koechkevin
approved these changes
Dec 4, 2024
apps/climatemappedafrica/src/components/HURUmap/CategoryHeader/index.js
Outdated
Show resolved
Hide resolved
m453h
approved these changes
Dec 4, 2024
apps/climatemappedafrica/src/components/HURUmap/ChartFilter/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Kipruto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
useStylesfrom HURUMapType of change
Screenshots
Checklist: